Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in docs/ref/contrib/postgres/fields.txt. #13277

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

b0uh
Copy link
Contributor

@b0uh b0uh commented Aug 5, 2020

I noticed there was a missing parenthesis in the documentation for a code excerpt.

I'm not sure if the indentation is quite right though.

Copy link

@vsasvipul0605 vsasvipul0605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just add brackets in two different lines for proper indentation

@b0uh
Copy link
Contributor Author

b0uh commented Aug 5, 2020

just add brackets in two different lines for proper indentation

I'm not sure where to put brackets 🤔 I was thinking maybe of doing something like that:

Event.objects.filter(
    start__contained_by=DateTimeTZRange(
        timezone.now() - datetime.timedelta(hours=1),
        timezone.now() + datetime.timedelta(hours=1),
    )
)

Or just keep the initial indentation.

@felixxm felixxm force-pushed the documentation_missing_parenthesis branch from 8925855 to cdead4f Compare August 7, 2020 05:35
@felixxm felixxm changed the title Add missing parenthesis in documentation Fixed typo in docs/ref/contrib/postgres/fields.txt. Aug 7, 2020
@felixxm
Copy link
Member

felixxm commented Aug 7, 2020

@b0uh Thanks 👍 Welcome aboard ⛵

@felixxm felixxm merged commit cdead4f into django:master Aug 7, 2020
@b0uh b0uh deleted the documentation_missing_parenthesis branch August 7, 2020 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants