Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added app labels to related fields checks messages E302-E305. #13819

Merged
merged 2 commits into from
Dec 29, 2020
Merged

Added app labels to related fields checks messages E302-E305. #13819

merged 2 commits into from
Dec 29, 2020

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Dec 28, 2020

I think it's worth to add app labels to these checks.

Noticed on a sample project attached to the ticket-32294:

app_a.TheSameNamedModel.buggy_m2m: (fields.E305) Reverse query name for 'TheSameNamedModel.buggy_m2m' clashes with reverse query name for 'TheSameNamedModel.buggy_m2m'.
        HINT: Add or change a related_name argument to the definition for 'TheSameNamedModel.buggy_m2m' or 'TheSameNamedModel.buggy_m2m'.
app_b.TheSameNamedModel.buggy_m2m: (fields.E305) Reverse query name for 'TheSameNamedModel.buggy_m2m' clashes with reverse query name for 'TheSameNamedModel.buggy_m2m'.
        HINT: Add or change a related_name argument to the definition for 'TheSameNamedModel.buggy_m2m' or 'TheSameNamedModel.buggy_m2m'.

carltongibson
carltongibson approved these changes Dec 29, 2020
View reviewed changes
Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, good. Thanks @felixxm 👍

@felixxm felixxm merged commit 4551993 into django:master Dec 29, 2020
@felixxm felixxm deleted the related_checks branch December 29, 2020 08:01
@felixxm
Copy link
Member Author

felixxm commented Dec 29, 2020

Thanks for checking 🎄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carltongibson carltongibson carltongibson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@felixxm @carltongibson