Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved pagination documentation #13991

Merged
merged 1 commit into from Feb 11, 2021
Merged

Improved pagination documentation #13991

merged 1 commit into from Feb 11, 2021

Conversation

adamchainz
Copy link
Sponsor Member

  • Link to the topic guide
  • Document that page() can raise PageNotAnInteger.

@adamchainz
Improved pagination documentation
650561a 
* Link to the topic guide
* Document that page() can raise PageNotAnInteger.
ngnpope
ngnpope approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@ngnpope ngnpope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Adam. These look good.

carltongibson
carltongibson approved these changes Feb 11, 2021
View reviewed changes
Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, super. Thanks @adamchainz.

@carltongibson carltongibson merged commit a57e91a into django:master Feb 11, 2021
@adamchainz adamchainz deleted the improve_pagination_documentation branch February 11, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carltongibson carltongibson carltongibson approved these changes

@ngnpope ngnpope ngnpope approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@adamchainz @carltongibson @ngnpope