Fixed #32493 -- Removed redundant never_cache uses from admin views.

[tim-mccurrach]

Decorating logout and index with never_cache is not needed, since admin_view already applies never_cache.

https://code.djangoproject.com/ticket/32493#ticket

[carltongibson]

OK, this seems reasonable to me.

• Coverage is provided by admin_views.tests.NeverCacheTests
• logout inherits never_cache from django.contrib.auth.views.LogoutView

I don't think it's supported usage to directly access the index or logout views, but I added a small release note for the behaviour change.

[tim-mccurrach]

@carltongibson Thanks for the review :)

I didn't think about accessing these methods directly, but agree with everything you've said.

Shouldn't the release note only mention index, not logout, since (as you mention) logout is covered by LogoutView?

[carltongibson]

Hey @tim-mccurrach — yes, that's a good point. I've adjusted the release note accordingly, squashed, rebased and used the project commit message format.

@felixxm Can I leave this here for you to glance at, in case you have a concern. (As we discussed I don't think there's an issue — if you're overriding, say, admin_view and not applying never_cache then you're on your own I'd argue...) Thanks!

[tim-mccurrach]

It's just occurred to me that login doesn't need never_cache either since that will be applied by auth.views.LoginView. I'll remove that one as well.

[carltongibson]

@tim-mccurrach I'd leave that one.

That never_cache is applied is obvious from the use of the admin_view decorator. login is one case we don't apply the wrap, so that it's decorated is clear. If we're relying on the decoration of the superclass it becomes mysterious.

[tim-mccurrach]

@tim-mccurrach I'd leave that one.

That never_cache is applied is obvious from the use of the admin_view decorator. login is one case we don't apply the wrap, so that it's decorated is clear. If we're relying on the decoration of the superclass it becomes mysterious.

Yes, that's a good point. Thank you

[felixxm]

Thanks both 👍