Refs CVE-2021-31542 -- Skipped mock AWS storage test on Windows. #14353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixxm
approved these changes
May 6, 2021
The validate_file_name() sanitation introduced in 0b79eb3 correctly rejects the example file name as containing path elements on Windows. This breaks the test introduced in 914c72b to allow path components for storages that may allow them. Test is skipped pending a discussed storage refactoring to support this use-case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validate_file_name() sanitation introduced in
0b79eb3 correctly rejects the example file
name as containing path elements on Windows. This breaks the test introduced in
914c72b to allow path components for storages
that may allow them.
Test is skipped pending a discussed storage refactoring to support this
use-case.