New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #33163 -- Added example of connection signal handlers in AppConfig.ready() to docs. #14925
Fixed #33163 -- Added example of connection signal handlers in AppConfig.ready() to docs. #14925
Conversation
Hello @roxanebellot! Thank you for your contribution 💪 As it's your first contribution be sure to check out the patch review checklist. If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket! If you have any design or process questions then you can ask in the Django forum. Welcome aboard ⛵️! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roxanebellot Thanks for this patch 👍 I don't think that a separate section is needed. I would add an example to the existing admonition. Please try to avoid unnecessary blank lines.
38305df
to
9b217b7
Compare
Hi ! Thank ou for your interest, blank lines are chopped ✔️ Can you confirm that a subsection is unfit compared to using an admonition ? We would loose the benefit of the anchor and maybe legibility too (it would be a big green zone) Also, i am having doubts about the title "Where should this code live" but if it's ok with you, it's ok with me. |
Yes: "I don't think that a separate section is needed. I would add an example to the existing admonition.". IMO a longer admonition doesn't affect readability. |
96c252a
to
45d6d56
Compare
…fig.ready() to docs.
@roxanebellot Thanks for updates 👍 Welcome aboard ⛵ I pushed small edits. |
45d6d56
to
2d124f6
Compare
Thanks @roxanebellot and @felixxm ! |
See ticket and forum post
I tried to keep as much as existing naming and formulation as I could.
When it is ok with you, I can also do a French translation