Grammer Updates #16290
Merged
Grammer Updates #16290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/topics/settings.txt
Outdated
| Also note that your code should *not* import from either ``global_settings`` or | ||
| Also, note that your code should *not* import from either ``global_settings`` or |
There was a problem hiding this comment.
Given that the preceding point is Note I think it's correct to Also note, rather than Also, note. Given that this would require a wrapping change, I don't think it's worth it.
docs/topics/settings.txt
Outdated
| used in that code you are importing. Check in | ||
| used in the code you are importing. Check-in |
There was a problem hiding this comment.
I don't think the hyphen is great there. We're saying to check (one thing) in (another thing) this folder. We're not referring to a single thing, such as a check-in you might do on a social media app (say).
the s/that/the/ seems right. 👍
carltongibson
force-pushed
the
patch-8
branch
from
eff979f
to
55014e0
Compare
carltongibson
force-pushed
the
patch-8
branch
from
55014e0
to
d526d15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made few Grammer Changes