Bootstrapped Django 5.0. #16432

felixxm · 2023-01-06T08:44:44Z

(to be merged after the stable/5.0.x branch is created)

timgraham · 2023-01-06T14:37:48Z

A couple of days ago, I noticed that the 4.0 release notes don't include the "Third-party library support for older version of Django" section that's in the 3.0 release notes. It probably doesn't need to be added there at this point, but it could be useful to add it to 5.0.

emarhin

i think everything is fine

felixxm · 2023-01-06T18:43:13Z

A couple of days ago, I noticed that the 4.0 release notes don't include the "Third-party library support for older version of Django" section that's in the 3.0 release notes. It probably doesn't need to be added there at this point, but it could be useful to add it to 5.0.

Thanks 👍 Added.

tests/forms_tests/field_tests/test_decimalfield.py

felixxm · 2023-01-06T18:54:00Z

I'm going to continue next week.

claudep

I think you made a good job here, really.
While reviewing, I noticed we have a serious problem with Form.localize/Widget.is_localized attributes which are basically not doing what they should as per the documentation. They are mostly initialized as False while the values are still localized. But of course, working on this issue is not the objective of this PR.
These changes also show that the various date format settings in global settings will be hardly usable in practice (unless some work is done on Field.localize, defaulting to True and make False value have real effects).

docs/topics/i18n/formatting.txt

tests/forms_tests/widget_tests/test_datetimeinput.py

felixxm · 2023-01-07T18:01:30Z

@claudep Thanks for the review ⭐

django/contrib/auth/views.py

django/db/backends/sqlite3/_functions.py

carltongibson

Hey @felixxm — looks really good.

My only real comment is the zoneinfo being universally available now, so the imports can be simplified and the backports.zoneinfo dependencies removed. (I can pick this up first thing Tuesday if you want to collapse on it 🙂)

Thanks so much for the sterling effort here! 🎁

django/templatetags/tz.py

tests/requirements/py3.txt

carltongibson

@felixxm I'm approving ~~modulo the previous comment~~ (#16432 (comment)) in case you want to push on on Monday!

docs/faq/install.txt

…timeline.

…ict/ErrorList. Per deprecation timeline.

…eline.

…precation timeline.

…ed_property(). Per deprecation timeline.

…timeline.

…ase.assertFormError()/assertFormsetErrors(). Per deprecation timeline.

…eError after prefetch_related(). Per deprecation timeline.

…ated filters. Per deprecation timeline.

…ackend.configure_user() subclasses. Per deprecation timeline.

Per deprecation timeline.

…line.

…ormset name to SimpleTestCase.assertFormError()/assertFormSetError(). Per deprecation timeline.

…deprecation timeline.

…r per deprecation timeline.

…v-based. Per deprecation timeline. This also removes "django/forms/default.html" and "django/forms/formsets/default.html" templates.

…ror when nulls_first/nulls_last=False is passed. Per deprecation timeline.

… is overridden.

timgraham · 2023-01-25T20:16:42Z

docs/releases/5.0.txt

+:mod:`django.contrib.admindocs`
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+* The default iteration count for the PBKDF2 password hasher is increased from


This belongs in the auth section, not admindocs. ;-)

Thanks!

Moved release note about the default PBKDF2 iterations into django.contrib.auth section. #16500

felixxm force-pushed the django50 branch from 810cd88 to ee2bae0 Compare January 6, 2023 12:14

emarhin approved these changes Jan 6, 2023

View reviewed changes

felixxm force-pushed the django50 branch from ee2bae0 to f1268d1 Compare January 6, 2023 18:43

felixxm commented Jan 6, 2023

View reviewed changes

tests/forms_tests/field_tests/test_decimalfield.py Show resolved Hide resolved

felixxm force-pushed the django50 branch from f1268d1 to cf603cd Compare January 6, 2023 18:47

claudep reviewed Jan 7, 2023

View reviewed changes

docs/topics/i18n/formatting.txt Outdated Show resolved Hide resolved

tests/forms_tests/widget_tests/test_datetimeinput.py Outdated Show resolved Hide resolved

felixxm force-pushed the django50 branch from cf603cd to 42eb1db Compare January 7, 2023 18:01

felixxm force-pushed the django50 branch 10 times, most recently from 1abce32 to de74147 Compare January 13, 2023 09:30

felixxm changed the title ~~[WiP] Bootstrapped Django 5.0.~~ Bootstrapped Django 5.0. Jan 13, 2023

felixxm marked this pull request as ready for review January 13, 2023 10:00

felixxm requested a review from carltongibson January 13, 2023 13:05

ngnpope reviewed Jan 13, 2023

View reviewed changes

django/contrib/auth/views.py Show resolved Hide resolved

carltongibson reviewed Jan 13, 2023

View reviewed changes

django/db/backends/sqlite3/_functions.py Show resolved Hide resolved

carltongibson reviewed Jan 13, 2023

View reviewed changes

django/templatetags/tz.py Show resolved Hide resolved

tests/requirements/py3.txt Show resolved Hide resolved

carltongibson approved these changes Jan 13, 2023

View reviewed changes

carltongibson reviewed Jan 13, 2023

View reviewed changes

docs/faq/install.txt Show resolved Hide resolved

Bumped version; master is now 5.0 pre-alpha.

a56dc90

felixxm added 22 commits January 17, 2023 08:52

Refs #27674 -- Removed GeoModelAdmin and OSMGeoAdmin per deprecation …

41ac74f

…timeline.

Refs #31026 -- Removed BaseForm._html_output() per deprecation timeline.

db9a0c3

Refs #31026 -- Removed ability to return string when rendering ErrorD…

94bbb46

…ict/ErrorList. Per deprecation timeline.

Refs #25916 -- Removed SitemapIndexItem.__str__() per deprecation tim…

2013a15

…eline.

Refs #32800 -- Removed CSRF_COOKIE_MASKED transitional setting per de…

af29139

…precation timeline.

Refs #30127 -- Removed name argument for django.utils.functional.cach…

6eb714d

…ed_property(). Per deprecation timeline.

Refs #33342 -- Removed ExclusionConstraint.opclasses per deprecation …

df743c9

…timeline.

Refs #33348 -- Removed support for passing errors=None to SimpleTestC…

24e0416

…ase.assertFormError()/assertFormsetErrors(). Per deprecation timeline.

Refs #29708 -- Removed PickleSerializer per deprecation timeline.

5a0e5d5

Refs #29984 -- Made QuerySet.iterator() without chunk_size raise Valu…

2e4d188

…eError after prefetch_related(). Per deprecation timeline.

Refs #31486 -- Removed ability to pass unsaved model instances to rel…

b76f446

…ated filters. Per deprecation timeline.

Refs #33561 -- Made created=True required in signature of RemoteUserB…

2e1aec2

…ackend.configure_user() subclasses. Per deprecation timeline.

Refs django#15619 -- Removed support for logging out via GET requests.

6c57c08

Per deprecation timeline.

Refs #32365 -- Removed django.utils.timezone.utc per deprecation time…

8e98dac

…line.

Refs #33348 -- Removed support for passing response object and form/f…

6840b6f

…ormset name to SimpleTestCase.assertFormError()/assertFormSetError(). Per deprecation timeline.

Refs #27674 -- Removed django.contrib.gis.admin.OpenLayersWidget per …

eaaa6d6

…deprecation timeline.

Refs #33691 -- Removed django.contrib.auth.hashers.CryptPasswordHashe…

fd5af39

…r per deprecation timeline.

Refs #32339 -- Changed default form and formset rendering style to di…

b602ea6

…v-based. Per deprecation timeline. This also removes "django/forms/default.html" and "django/forms/formsets/default.html" templates.

Refs #33543 -- Made Expression.asc()/desc() and OrderBy raise ValueEr…

03589bd

…ror when nulls_first/nulls_last=False is passed. Per deprecation timeline.

Refs #33263 -- Removed warning in BaseDeleteView when delete() method…

0996fb9

… is overridden.

Advanced deprecation warnings for Django 5.0.

56947bc

Increased the default PBKDF2 iterations for Django 5.0.

ee83fae

felixxm force-pushed the django50 branch from de74147 to ee83fae Compare January 17, 2023 07:52

carltongibson approved these changes Jan 17, 2023

View reviewed changes

felixxm merged commit 4fc711a into django:main Jan 17, 2023

felixxm deleted the django50 branch January 17, 2023 10:49

timgraham reviewed Jan 25, 2023

View reviewed changes

This was referenced May 3, 2024

5.0: Update django.contrib.gis.admin.widgets and django.contrib.gis.admin.options typeddjango/django-stubs#2116

Merged

5.0: Update django.forms.forms typeddjango/django-stubs#2122

Merged

saJaeHyukc mentioned this pull request May 16, 2024

5.0: Update django.db.models.functions.datetime typeddjango/django-stubs#2167

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bootstrapped Django 5.0. #16432

Bootstrapped Django 5.0. #16432

felixxm commented Jan 6, 2023

timgraham commented Jan 6, 2023

emarhin left a comment

felixxm commented Jan 6, 2023

felixxm commented Jan 6, 2023

claudep left a comment

felixxm commented Jan 7, 2023

carltongibson left a comment •

edited

carltongibson left a comment •

edited

timgraham Jan 25, 2023

felixxm Jan 25, 2023

Bootstrapped Django 5.0. #16432

Bootstrapped Django 5.0. #16432

Conversation

felixxm commented Jan 6, 2023

timgraham commented Jan 6, 2023

emarhin left a comment

Choose a reason for hiding this comment

felixxm commented Jan 6, 2023

felixxm commented Jan 6, 2023

claudep left a comment

Choose a reason for hiding this comment

felixxm commented Jan 7, 2023

carltongibson left a comment • edited

Choose a reason for hiding this comment

carltongibson left a comment • edited

Choose a reason for hiding this comment

timgraham Jan 25, 2023

Choose a reason for hiding this comment

felixxm Jan 25, 2023

Choose a reason for hiding this comment

carltongibson left a comment •

edited

carltongibson left a comment •

edited