Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc'd use of asgiref.sync adapters with sensitive variables. #16673

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

carltongibson
Copy link
Member

No description provided.

@carltongibson carltongibson changed the title Doc'd use of asgiref.sync adapters with senistive variables. Doc'd use of asgiref.sync adapters with sensitive variables. Mar 22, 2023
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carltongibson Thanks 👍 I left small suggestions.

docs/topics/async.txt Outdated Show resolved Hide resolved
docs/topics/async.txt Outdated Show resolved Hide resolved
docs/topics/async.txt Show resolved Hide resolved
@carltongibson
Copy link
Member Author

Should we mention the second decorator? django.views.decorators.debug.sensitive_post_parameters

I don't think this is necessary, since this is pulled off of the request object (rather than from the traceback frame via 🪄)

@carltongibson
Copy link
Member Author

@felixxm OK, updated. Let me know what you think. (As ever it's a bit Argh! 🤷 :)

Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carltongibson Thanks 👍

@carltongibson carltongibson merged commit b00046d into django:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants