Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed isolation of SeleniumTests.test_search_input_filtered_page() test. #17044

Merged
merged 2 commits into from Jul 4, 2023
Merged

Fixed isolation of SeleniumTests.test_search_input_filtered_page() test. #17044

merged 2 commits into from Jul 4, 2023

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Jul 4, 2023

Test crashed when the sidebar was not closed:

$ ./runtests.py --selenium=chrome --headless admin_views.tests.SeleniumTests.test_search_input_filtered_page

Testing against Django installed in '/django/django' with up to 8 processes
Found 1 test(s).
Creating test database for alias 'default'...
System check identified no issues (1 silenced).
F
======================================================================
FAIL: test_search_input_filtered_page (admin_views.tests.SeleniumTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/django/tests/admin_views/tests.py", line 6294, in test_search_input_filtered_page
    self.assertGreater(
AssertionError: 40 not greater than 50

----------------------------------------------------------------------
Ran 1 test in 3.452s

FAILED (failures=1)
Destroying test database for alias 'default'...

Before:

screenshot

After:

screenshot_together

@felixxm felixxm requested a review from a team July 4, 2023 10:38
@felixxm felixxm added the selenium Apply to have Selenium tests run on a PR label Jul 4, 2023
sarahboyce and others added 2 commits July 4, 2023 13:34
@sarahboyce @felixxm
Made SeleniumTests.test_updating_related_objects_updates_fk_selects_e…
968684a 
…xcept_autocompletes() test less flaky by adding explicit Selenium wait.
@felixxm
Fixed isolation of SeleniumTests.test_search_input_filtered_page() test.
42b4f81 
Test crashed when the sidebar was not closed.
@felixxm felixxm force-pushed the test_search_input_filtered_page-isolation branch from 1728f10 to 42b4f81 Compare July 4, 2023 11:34
@felixxm felixxm merged commit 42b4f81 into django:main Jul 4, 2023
30 of 31 checks passed
@felixxm felixxm deleted the test_search_input_filtered_page-isolation branch July 4, 2023 12:12
@felixxm felixxm temporarily deployed to schedules July 5, 2023 03:01 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgaligniana mgaligniana mgaligniana approved these changes

Assignees
No one assigned
Labels
selenium Apply to have Selenium tests run on a PR
Projects
None yet
Milestone
No milestone
3 participants
@felixxm @mgaligniana @sarahboyce