Improved DEFAULT_FROM_EMAIL/SERVER_EMAIL docs. #17610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nessita
reviewed
Dec 18, 2023
|
The suggested changes are fine by me, they are an improvement to the existing documentation, and I like the conciseness. Thank you for reviewing this. I accepted the changes, deleted a duplicate sentence, squashed the changes into a new commit, and pushed to this pull request. |
Flimm
force-pushed
the
doc-from-email
branch
from
5016bb2
to
07a63d5
Compare
felixxm
changed the title
Co-authored-by: nessita <124304+nessita@users.noreply.github.com>
felixxm
force-pushed
the
doc-from-email
branch
from
07a63d5
to
61aae83
Compare
felixxm
reviewed
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These settings only affect the
Fromheader set in sent emails. They do not affect other things, such as the SMTP username used to authenticate, and they may be different from the SMTP username. This change clarifies the role of these settings, in order to prevent confusion.This change also documents how to set a name alongside an email address in the
Fromheader of these emails.