Fixed #34910 -- Improved color contrast for add/change icons in admin.

[Hisham-Pak]

Ticket: https://code.djangoproject.com/ticket/34910

[thibaudcolas]

Thank you for giving this a go @Hisham-Pak, could you confirm what you’ve done to test this?

In particular I believe this needs further work for support of the admin’s dark theme – have you tested that?

[Hisham-Pak]

Hi @thibaudcolas, thank you for your review. I have visually inspected the color and also looked for its occurrences elsewhere (didn't find any issues). It has passed the contrast test as well (although contrast ratio did decrease a little bit on dark mode). If there’s anything I might have overlooked, please let me know. Here’s how the changes appear in the current context:

Light Mode

Dark Mode

[thibaudcolas]

Thank you @Hisham-Pak, my bad! This looks spot on, tested in light and dark mode though obviously the contrast grid you provided is enough to validate the change. Thank you for providing the screenshots in addition.

[felixxm]

@thibaudcolas Thanks for the review 👍 We don't use labels to categorize PRs, you don't need to add them.

[felixxm]

@Hisham-Pak Thanks 👍 Welcome aboard ⛵