Added flake8 and isort lint tests ( #43)

django · May 3, 2022 · 4c88fa8 · 4c88fa8
1 parent f4100ff
commit 4c88fa8
Show file tree

Hide file tree

Showing 7 changed files with 41 additions and 7 deletions.
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -0,0 +1,34 @@
+name: Lint
+
+on:
+  pull_request: 
+  push:
+    branches:
+      - master
+
+jobs:
+  flake8: 
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+      - name: Set up python
+        uses: actions/setup-python@v3
+        with:
+          python-version: '3.10'
+      - run: pip install flake8
+      - name: flake8
+        run: flake8 .
+
+  isort:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+      - name: Set up python
+        uses: actions/setup-python@v3
+        with:
+          python-version: '3.10'
+      - run: pip install isort
+      - name: isort
+        run: isort --check .
diff --git a/djangobench/benchmarks/query_prefetch_related/benchmark.py b/djangobench/benchmarks/query_prefetch_related/benchmark.py
@@ -12,7 +12,7 @@ def benchmark():
 
 def setup():
     global Author
-    from query_prefetch_related.models import Book, Author
+    from query_prefetch_related.models import Author, Book
     for i in range(0, 20):
         a = Author.objects.create(author="Author %s" % i)
         books = [Book.objects.create(title="Title %s" % j) for j in range(0, 3)]

diff --git a/djangobench/benchmarks/url_resolve/views.py b/djangobench/benchmarks/url_resolve/views.py
@@ -1,5 +1,6 @@
 from django.http import HttpResponse
 
+
 def basic(request):
     return HttpResponse()
 

diff --git a/djangobench/benchmarks/url_resolve_flat/benchmark.py b/djangobench/benchmarks/url_resolve_flat/benchmark.py
@@ -1,5 +1,5 @@
 try:
-    from django.urls import resolve, Resolver404
+    from django.urls import Resolver404, resolve
 except ImportError:  # Django < 1.10
     from django.core.urlresolvers import resolve, Resolver404
 

diff --git a/djangobench/benchmarks/url_resolve_flat_i18n_off/benchmark.py b/djangobench/benchmarks/url_resolve_flat_i18n_off/benchmark.py
@@ -1,5 +1,5 @@
 try:
-    from django.urls import resolve, Resolver404
+    from django.urls import Resolver404, resolve
 except ImportError:  # Django < 1.10
     from django.core.urlresolvers import resolve, Resolver404
 

diff --git a/djangobench/perf.py b/djangobench/perf.py
@@ -75,19 +75,19 @@
 __author__ = "jyasskin@google.com (Jeffrey Yasskin)"
 
 try:
-    from urllib.request import urlopen
     from urllib.error import URLError
+    from urllib.request import urlopen
 except ImportError:
-    from urllib2 import urlopen, URLError
+    from urllib2 import URLError, urlopen
 try:
     import multiprocessing
 except ImportError:
     multiprocessing = None
 try:
+    import pywintypes
     import win32api
     import win32con
     import win32process
-    import pywintypes
 except ImportError:
     win32api = None
 

diff --git a/setup.cfg b/setup.cfg
@@ -9,4 +9,3 @@ include_trailing_comma = true
 known_first_party = djangobench
 line_length = 79
 multi_line_output = 5
-not_skip = __init__.py