Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some styling for the trac #103

Closed
olasitarska opened this issue Nov 16, 2014 · 13 comments
Closed

Add some styling for the trac #103

olasitarska opened this issue Nov 16, 2014 · 13 comments
Assignees
Milestone

Comments

@olasitarska
Copy link
Contributor

No description provided.

@olasitarska olasitarska modified the milestone: Redesign launch Nov 17, 2014
@olasitarska
Copy link
Contributor Author

I think we will need an access to code.djangoproject.com here :) Anyone? @jezdez

@jezdez
Copy link
Contributor

jezdez commented Nov 20, 2014

Trac's code is hosted in a different repo (https://github.com/django/code.djangoproject.com), I just added it to the redesign team. Please also work in a branch and open a PR there so that we can track it properly. Thanks!

@olasitarska
Copy link
Contributor Author

Thanks @jezdez! 💫

@aaugustin
Copy link
Member

Trac is known to be hard to set up and run locally. Grabbing the HTML source and working on a static copy locally might be the best solution :-(

@olasitarska
Copy link
Contributor Author

Thanks for the tip, @aaugustin :)

@olasitarska olasitarska self-assigned this Nov 22, 2014
@bmispelon bmispelon assigned bmispelon and unassigned olasitarska Nov 22, 2014
@bmispelon
Copy link
Member

Managed to get it somewhat installed locally. Let's see if I can get something half-decent working.

@bmispelon
Copy link
Member

I just pushed a first version of this (django/code.djangoproject.com@131e8d8).

To test it out:

  • clone django/code.djangoproject.com
  • cd code.djangoproject.com
  • pip install -r requirements.txt # In same virtualenv as djangoproject.com probably
  • Follow all steps of djangoproject.com/README.txt (especially creating database/user and loading trac.sql)
  • psql -U code.djangoproject -d code.djangoproject -c "INSERT INTO permission (username, action) VALUES ('anonymous', 'TRAC_ADMIN')"
  • tracd --port 9000 -s trac-env

You might also want to set secure_cookies = false in trac-env/conf/trac.ini if you want to be able to create some content (wiki or tickets). Setting base_url (in [trac]) and url (in [project]) to your localhost URL might also help for testing out things like search.

There are still quite a few things to change, most of them caused by weird interactions between our new styles and trac's ones. The old trac-env/htdocs/style.css was used before to change stuff like colors to match our palette. Depending on how much efforts we want to put into this, it might be enough to just fix a few colors and call it a day.

@olasitarska
Copy link
Contributor Author

Thanks @bmispelon, I got it running now too! This is really awesome. 🎉

I'll try to work on more css changes tomorrow morning :) Thank you for help!

@olasitarska
Copy link
Contributor Author

I added some more styling. Currently I am on the stage when I want to throw my computer outside the window because of this terrible trac css, so I'm going to take a break for few hours... 🙀

@oinopion
Copy link
Contributor

@olasitarska in those moments you should definitely visit: http://ladydinahs.com/

@olasitarska
Copy link
Contributor Author

OMG this is amazing! 😹

@bmispelon
Copy link
Member

I pushed another commit for this (2d7274f459ecaad622ed9a4c93e290a0d02ab451) and I think we're pretty much done now.

I removed all the ugly trac colors I could find (default reds and browns) and replaced them with the greens from our styleguide.

Can someone double-check and close this?

@olasitarska
Copy link
Contributor Author

Amazing effort @bmispelon, trac looks as good as it possibly can! 💖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants