Fix INVALID_FILE_ATTRIBUTES for x64 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The GetFileAttributes Win32 API call returns a DWORD, which is a platform independent 32-bit wide unsigned integer: http://msdn.microsoft.com/en-us/library/windows/desktop/aa364944(v=vs.85).aspx It's max value is 4294967295: http://msdn.microsoft.com/en-us/library/windows/desktop/aa383751(v=vs.85).aspx - FFI::Pointer.new(-1).address is platform dependent and on x64 is 18446744073709551615, which is the max value of a 64-bit wide unsigned integer. - The INVALID_FILE_ATTRIBUTES constant is a valid return value of GetFileAttributes and is defined in winbase.h as: #define INVALID_FILE_ATTRIBUTES ((DWORD)-1) - Therefore INVALID_FILE_ATTRIBUTES should be defined as 0xFFFFFFFF
|
@djberg96 this one is a bit blocking for us... |
|
Ok. |
djberg96
added a commit
that referenced
this pull request
Jul 2, 2014
Fix INVALID_FILE_ATTRIBUTES for x64
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unsigned integer:
http://msdn.microsoft.com/en-us/library/windows/desktop/aa364944(v=vs.85).aspx
It's max value is 4294967295:
http://msdn.microsoft.com/en-us/library/windows/desktop/aa383751(v=vs.85).aspx
the max value of a 64-bit wide unsigned integer.
#define INVALID_FILE_ATTRIBUTES ((DWORD)-1)