Encode CSIDL strings as ascii_compatible #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby does not allow `File.join` to be called with non-ascii_compatible
encoded strings, like `UTF-16LE`[1]. As a result, if any of the CSIDL
constants, e.g. COMMON_APPDATA, are used in `File.join` it fails with:
irb(main):001:0> require 'win32/dir'
irb(main):002:0> File.join(Dir::COMMON_APPDATA, 'foo')
ArgumentError: string contains null byte
The ffi branch calls the wide versions of `SHGetFolderPathW`, and appears
to always have this issue. The master branch calls the ANSI versions, which
only exhibit the problem when using a non-ASCII locale, e.g. Italian
(locale 0410).
This commit ensures all CSIDL constants are encoded using the default
external encoding, similar to what is done for `Dir::getwd`.
Note I suspect the junction code has the same problem, e.g. `read_junction`.
[1] https://bugs.ruby-lang.org/issues/7168
|
indeed, the Dir::COMMON_APPDATA fails (Windows 7, Bulgarian Locale, Ruby 1.9.3-p194) |
djberg96
added a commit
that referenced
this pull request
Jul 12, 2013
Encode CSIDL strings as ascii_compatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby does not allow
File.jointo be called with non-ascii_compatibleencoded strings, like
UTF-16LE[1]. As a result, if any of the CSIDLconstants, e.g. COMMON_APPDATA, are used in
File.joinit fails with:The ffi branch calls the wide versions of
SHGetFolderPathW, and appearsto always have this issue. The master branch calls the ANSI versions, which
only exhibit the problem when using a non-ASCII locale, e.g. Italian
(locale 0410).
This commit ensures all CSIDL constants are encoded using the default
external encoding, similar to what is done for
Dir::getwd.Note I suspect the junction code has the same problem, e.g.
read_junction.[1] https://bugs.ruby-lang.org/issues/7168