Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported languages #16

Closed
rabelux opened this issue Oct 9, 2021 · 15 comments · Fixed by #68
Closed

Supported languages #16

rabelux opened this issue Oct 9, 2021 · 15 comments · Fixed by #68
Labels
enhancement New feature or request

Comments

@rabelux
Copy link
Contributor

rabelux commented Oct 9, 2021

Does the new plugin support other sites than audible.com? Like audible.de, .fr, ...

@djdembeck
Copy link
Owner

Not currently. I need to determine the best structure for supporting other regions first, then I can see how feasible non-English regions will be

@rabelux
Copy link
Contributor Author

rabelux commented Oct 11, 2021

I guess I'll better stick with the old plugin until this is on your roadmap, let me know if I can be of any help.

I'm a bit surprised though that you went ahead and wrote a completely new backend + plugin!
The old plugin maybe had its flaws but it basically got the job done, so I'm a bit curious what motivated you to do so?

@djdembeck
Copy link
Owner

The roadmap is currently:
Support multi-regions (en) -> support multi-regions (other). There's probably some modularization I need to do on the backend for it. Hope to get it done this week, depending on the scale of what needs to change.

Yep, I had other applications that all were making their own audible calls, and none got all the data they needed. I figured it would be most beneficial to write a single point of contact for all my services

@mmuenker
Copy link

is there any news to this? This currently breaks the audiobookshelf book match feature: advplyr/audiobookshelf#731 (comment)

@djdembeck
Copy link
Owner

It doesn't break anything, because it's not even a feature.

@baloodusudouest
Copy link

if this can help, for french for ex, seanap work on a files to find the information on the audible french information to put on the mp3tag
https://github.com/seanap/Plex-Audiobook-Guide/blob/master/mp3tag/data/sources/Audible.fr%23Search%20by%20Album.src

@djdembeck
Copy link
Owner

Pending upstream implementation then I can get to writing the plugin update: laxamentumtech/audnexus#498

@rabelux
Copy link
Contributor Author

rabelux commented Sep 24, 2022

Awesome! Appreciate it 😃

@Hoempi
Copy link

Hoempi commented Sep 24, 2022

Great news, looking forward to it. Thank you very much!

@djdembeck
Copy link
Owner

djdembeck commented Sep 30, 2022

Going well so far. Here's an author taken from ?region=de:

{
    "asin": "B001JSF77S",
    "description": "Vom Radio-Unterhalter zum Autor von Psychothrillern – ein Kontrast, wie er sich auch in Sebastian Fitzeks Romanen entfaltet. Alltägliche Situationen entwickeln sich bei ihm zu düsteren Szenarien. Mit „Die Therapie“ gelang ihm 2006 der Durchbruch. Seitdem sind seine Krimis aus den deutschen Bestsellerlisten nicht mehr wegzudenken. 1971 in Berlin geboren, wurde Sebastian Fitzek 2016 als erster deutscher Autor mit dem renommierten „Europäischen Preis für Kriminalliteratur“ ausgezeichnet.Temporeiche Erzählweise Er bedient sich zahlreicher Cliffhanger, die seine packende Erzählweise an den Stil amerikanischer Thriller erinnern lässt. Als Ur - Berliner verlegt er seine Handlungen oft an Schauplätze in Berlin und macht das Grauen damit fast greifbar.Gänsehaut pur Das Erfolgsrezept für Fitzeks literarischen Nervenkitzel ist die Schocktherapie. Aus der Annahme eines Pakets für den Nachbarn oder einem gewöhnlichen Langstreckenflug entwickelt der Autor die Geschichte zu einer Art Worst - Case - Szenario.Er spielt dabei mit Urängsten wie der Verfolgungsangst oder dem Ausgeliefertsein– Themen, die gerade im Hörbuchformat für noch mehr Gänsehautfeeling sorgen.",
    "genres": [
        {
            "asin": "16209910031",
            "name": "Krimis & Thriller",
            "type": "genre"
        },
        {
            "asin": "16206595031",
            "name": "Kunst & Unterhaltung",
            "type": "genre"
        },
        {
            "asin": "16209739031",
            "name": "Literatur & Belletristik",
            "type": "genre"
        }
    ],
    "image": "https://images-na.ssl-images-amazon.com/images/S/amzn-author-media-prod/rjtjrte07nuucmkjhrc08rtst8.jpg",
    "name": "Sebastian Fitzek",
    "region": "de"
}

The Audnexus agent must have a single region/language set as default for auto matching. But I imagine an overriding search for another region/language would be fine.

@djdembeck
Copy link
Owner

This is all ready to go upstream 🥳 Will try to work on it some this week, as the agent needs a bit of an overhaul to handle searching in the other regions.

@djdembeck
Copy link
Owner

djdembeck commented Oct 7, 2022

For anyone feeling adventurous, you can try the new region options in the branch feat-multi-region and follow the PR for progress: #66

@djdembeck djdembeck linked a pull request Oct 19, 2022 that will close this issue
@djdembeck
Copy link
Owner

Multi region support is now live in the develop branch. I've only tested [us] and [uk] regions specifically, so please test it and see what happens :)

@Hoempi
Copy link

Hoempi commented Oct 20, 2022

I have been using it via audiobookshelf for a while now. Works well for me with audible.de. Thanls for making it possible!

Sometimes it is strange that I do not find a German book using audible.de, but using the same author and title I do find it on audible.com. But I would attribute that to Amazon/Audible not being consisten. As with their ASINs, sometimes it is the same for .de and .com and sometimes it differs, even though it si the exact same edition.

@rubbishgee
Copy link

rubbishgee commented Oct 30, 2022

Thanks for doing this. But as well with the develop branch and the feat-multi-region branch i don't have any results no matter what i type in and no matter what region i,m using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants