Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for name_to_initials() #62

Merged
merged 1 commit into from Sep 14, 2022
Merged

Conversation

rabelux
Copy link
Contributor

@rabelux rabelux commented Sep 12, 2022

I don't know why I thought using a list comprehension and f-strings improves the code, following the KISS principle the change I made in this commit is all that should have been done in the first place. So please dump my previous PR. Tested in Python 2.7 REPL.

@djdembeck
Copy link
Owner

Nice! Did you test your previous cases again with this change?

        Examples:
            'Arthur Conan Doyle' -> 'A.C.Doyle'
            'J.K. Rowling'       -> 'J.K.Rowling'
            'J. R. R. Tolkien'   -> 'J.R.R.Tolkien'

@rabelux
Copy link
Contributor Author

rabelux commented Sep 12, 2022

Yes I did and I'd suggest to expand the examples with any edge case that gets discovered.
Could you create a doctoring including an example for clear_contributor_text()?

@djdembeck
Copy link
Owner

djdembeck commented Sep 14, 2022

Could you create a doctoring including an example for clear_contributor_text()?

Can you rephrase this? I'm not sure I understand.

@rabelux
Copy link
Contributor Author

rabelux commented Sep 14, 2022

I meant docstring aka function description. Clear now?

@djdembeck
Copy link
Owner

I meant docstring aka function description. Clear now?

Yes! Thank you for clarifying. I will add one after merging this.

Thanks again for the PR!

@djdembeck djdembeck merged commit d345713 into djdembeck:develop Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants