Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of the project re. upstream and licensing #71

Open
fgaz opened this issue Jan 24, 2024 · 4 comments
Open

Status of the project re. upstream and licensing #71

fgaz opened this issue Jan 24, 2024 · 4 comments

Comments

@fgaz
Copy link

fgaz commented Jan 24, 2024

Hi! I'm the packager of upstream lgpt for NixOS, and now that this fork got a stable release I'm considering it for inclusion/replacement of lgpt, but there are a couple issues stopping me.

  1. The relationship of this project with upstream is unclear. "LittleGPTracker" is @Mdashdotdashn's project, having two projects with the same name is confusing. I can see two possible solutions.
    1. @Mdashdotdashn agrees to make you a maintainer of the upstream project, or nominates this fork as successor.
    2. The name of this fork is changed. It does not have to be totally different. It can be as simple as LittleGPTracker-ng or LittleGPTracker-enhanced.
  2. Most importantly, the change to CC-BY-NC-SA is unfortunate, because it isn't a FOSS license due to the NC clause. It prevents inclusion in many distros, and imposes heavy limitations. Furthermore, Creative Commons is not recommended for code. Could you consider reverting to MIT while it's still possible, or switching to another FOSS license intended for code (GPL, EUPL, MPL, BSD...)?
@djdiskmachine
Copy link
Owner

Fair points! I'll look into changing the name of the repo, something like LittlePiggyTracker-featuredevelopment or something less long.

I'll look into which of those licenses fits best, Thanks for the recommendations :)

How have you handled building for x86_64 for NixOs?

@djdiskmachine
Copy link
Owner

Oh i just found this, that's great to know!
I'll apply this patch to my 64bit branch and check if soundfonts still work :)
https://github.com/NixOS/nixpkgs/blob/66a9817cec77098cfdcbb9ad82dbb92651987a84/pkgs/applications/audio/littlegptracker/0001-Remove-coherency-checks.patch#L12

@fgaz
Copy link
Author

fgaz commented Jan 24, 2024

I'll look into which of those licenses fits best, Thanks for the recommendations :)

Awesome, thank you for keeping the project FOSS!

I'll look into changing the name of the repo

Looks like it won't be necessary! I emailed Marc, who agreed to join forces and make you a maintainer of upstream lgpt if you're ok with that.

Oh i just found this, that's great to know!
I'll apply this patch to my 64bit branch and check if soundfonts still work :)
https://github.com/NixOS/nixpkgs/blob/66a9817cec77098cfdcbb9ad82dbb92651987a84/pkgs/applications/audio/littlegptracker/0001-Remove-coherency-checks.patch#L12

Yes that's it, and please do check! I'm not 100% sure it's ok, and the optimal way to fix it is probably to retype the library, as @Mdashdotdashn suggests here Mdashdotdashn#4 (comment)

@peterswimm
Copy link

LittlePGTracker!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants