Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on vscode-extension-tester-native which is deprecated #44

Closed
apupier opened this issue Nov 25, 2021 · 4 comments
Closed

Remove dependency on vscode-extension-tester-native which is deprecated #44

apupier opened this issue Nov 25, 2021 · 4 comments
Labels
DEPENDENCIES Issues or Pull requests that update a dependency file PRIO Pull request or Issue with high priority

Comments

@apupier
Copy link
Contributor

apupier commented Nov 25, 2021 •
edited
Loading

see redhat-developer/vscode-extension-tester#396 (comment) and https://github.com/redhat-developer/vscode-extension-tester/blob/master/CHANGELOG.md#420-sep-3
@apupier apupier changed the title Remove usage of vscode-extension-tester-native which is deprecated Remove dependency on vscode-extension-tester-native which is deprecated Nov 25, 2021
@apupier apupier mentioned this issue Nov 25, 2021
Closed
@apupier
Copy link
Contributor Author

apupier commented Nov 25, 2021

@jrichter Can you provide guidance on how to remove it from this library please?
it is used in https://github.com/djelinek/vscode-uitests-tooling/blob/master/src/components/Dialog.ts

@apupier
Copy link
Contributor Author

apupier commented Nov 25, 2021

In the wiki, it is still mentioning to use the native API https://github.com/redhat-developer/vscode-extension-tester/wiki/OpenDialog (I added a deprecated warning but woudl be nice habing mor einformation how to migrate

@mlorinc
Copy link
Contributor

mlorinc commented Nov 26, 2021

There is implemented modern solution in InputBoxOpenDialogs.ts but it might need some stabilization. In regard of native dialogs I will bring this topic in upcoming 1on1 with @djelinek.

@djelinek djelinek added DEPENDENCIES Issues or Pull requests that update a dependency file PRIO Pull request or Issue with high priority labels Nov 29, 2021
@apupier
Copy link
Contributor Author

apupier commented Jan 5, 2022

fixed in 2.2.1 release

@apupier apupier closed this as completed Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DEPENDENCIES Issues or Pull requests that update a dependency file PRIO Pull request or Issue with high priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@apupier @djelinek @mlorinc