New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The future of tokio in audioipc #97
Comments
Thanks for attempting this! There's no concrete plan to replace tokio at this stage, although it's a continuing thread of discussion. I've been meaning to try updating to tokio 0.2 to see what's involved as part of evaluating whether to continue with tokio or move to a solution better suited to AudioIPC's needs. Since it's important for us to control which threads various code runs on, we've (ab)used tokio's current_thread support for this... I haven't explored tokio 0.2's LocalSet in detail yet to see how it works as a replacement. When I have time I'll see if I can get ipctest working based on the changes in your branch. If you make any progress, please let me know. |
Pretty straightforward update. This duplicates the tokio stack because audioipc hasn't been updated yet. (mozilla/audioipc#97) Differential Revision: https://phabricator.services.mozilla.com/D71462
Pretty straightforward update. This duplicates the tokio stack because audioipc hasn't been updated yet. (mozilla/audioipc#97) Differential Revision: https://phabricator.services.mozilla.com/D71462 UltraBlame original commit: c65feea492118812556f2795f2d34728afe2d2ae
Pretty straightforward update. This duplicates the tokio stack because audioipc hasn't been updated yet. (mozilla/audioipc#97) Differential Revision: https://phabricator.services.mozilla.com/D71462 UltraBlame original commit: c65feea492118812556f2795f2d34728afe2d2ae
Pretty straightforward update. This duplicates the tokio stack because audioipc hasn't been updated yet. (mozilla/audioipc#97) Differential Revision: https://phabricator.services.mozilla.com/D71462 UltraBlame original commit: c65feea492118812556f2795f2d34728afe2d2ae
Pretty straightforward update. This duplicates the tokio stack because audioipc hasn't been updated yet. (mozilla/audioipc#97) Differential Revision: https://phabricator.services.mozilla.com/D71462
As mentioned here, the current plan is remove our dependency on tokio. That'll be tracked in bug 1697845. |
Hey, tried updating tokio in here this weekend, got it to compile but it's not working. When I asked on #media, I was told that audioipc might get off tokio in a soon-ish future. What's the state of that ? Should I bother trying to finish the tokio bump ?
My work is here: https://github.com/Eijebong/audioipc-2/tree/all-i-wanted-this-weekend-was-to-play-minecraft-I-failed
The text was updated successfully, but these errors were encountered: