server: Don't swallow errors in register_device_collection_changed. #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChunMinChang
approved these changes
Jul 29, 2019
server/src/server.rs
Outdated
| (true, false) => self.internal_register(context, dir, true), | ||
| (false, true) => self.internal_register(context, dir, false), | ||
| (true, false) => self.internal_register(context, dir, true)?, | ||
| (false, true) => self.internal_register(context, dir, false)?, |
There was a problem hiding this comment.
for &dir in &[cubeb::DeviceType::INPUT, cubeb::DeviceType::OUTPUT] {
if devtype.contains(dir) != self.devtype.contains(dir) {
self.internal_register(context, dir, devtype.contains(dir))?;
}
}will be shorter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swallowing errors (by converting them to panics via
expect) in CubebDeviceCollectionManager::internal_register is a bad idea: registration can fail for legitimate reasons plus we need to report CUBEB_ERROR_NOT_SUPPORTED correctly for unimplemented backends.This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1569460
r? @ChunMinChang please