Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log rather than assert unsuccessful stream/context callbacks. #38

Merged
merged 1 commit into from Jul 24, 2018
Merged

Conversation

kinetiknz
Copy link
Contributor

Fix for BMO bug 1471922.

Copy link
Collaborator

@djg djg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but success == 0 probably signifies something deeper. (Doesn't it mean that the command timed out and didn't complete?)

@djg djg merged commit 7988647 into dev Jul 24, 2018
@djg djg deleted the bmo1471922 branch July 24, 2018 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants