Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor base source code for FACS #34

Closed
djgroen opened this issue Jul 19, 2023 · 0 comments · Fixed by #37
Closed

Refactor base source code for FACS #34

djgroen opened this issue Jul 19, 2023 · 0 comments · Fixed by #37
Assignees
@arindamsaha1507 @mzrghorbani
Labels
enhancement New feature or request future-proofing
Milestone
FACS 2.0

Comments

@djgroen
Copy link
Owner

djgroen commented Jul 19, 2023

As per Maziar's suggestion, we should split off the source code a bit such that facs.py is a bit less overwhelming in size, and the code is easier to navigate for people other than me ;).
@djgroen djgroen added enhancement New feature or request future-proofing labels Jul 19, 2023
@djgroen djgroen added this to the FACS 2.0 milestone Jul 19, 2023
@arindamsaha1507 arindamsaha1507 linked a pull request Jul 24, 2023 that will close this issue
Refactoring #37
Merged
@arindamsaha1507 arindamsaha1507 mentioned this issue Jul 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arindamsaha1507 arindamsaha1507

@mzrghorbani mzrghorbani

Labels
enhancement New feature or request future-proofing
Projects
FACS 2.5 code + paper
Status: Done
Milestone
FACS 2.0
Development

Successfully merging a pull request may close this issue.

Refactoring djgroen/facs
3 participants
@djgroen @arindamsaha1507 @mzrghorbani