Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReturnOrThrowSniff false positive #178

Open
kick-the-bucket opened this issue Dec 31, 2019 · 0 comments
Open

ReturnOrThrowSniff false positive #178

kick-the-bucket opened this issue Dec 31, 2019 · 0 comments

Comments

@kick-the-bucket
Copy link

kick-the-bucket commented Dec 31, 2019 •
edited 

switch ($a) {
    case 'a':
        switch ($b) {
            case 'b':
                return 'c';
        }
        break;
}

The sniff is triggered on the return, but I think it shouldn't be, since a switch without a default: is not guaranteed to return something.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kick-the-bucket