Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get mypy setup on all files (except those generated by pyuic) #105

Closed
djotaku opened this issue Apr 12, 2020 · 0 comments
Closed

Get mypy setup on all files (except those generated by pyuic) #105

djotaku opened this issue Apr 12, 2020 · 0 comments
Assignees
@djotaku
Labels
mypy related to static typing in python
Milestone
5.0 The Third Gre...

Comments

@djotaku
Copy link
Owner

djotaku commented Apr 12, 2020

after issue #103 / could be done in parallel with issue #104

Static typing has helped a lot with finding errors.
@djotaku djotaku added the mypy related to static typing in python label Apr 12, 2020
@djotaku djotaku added this to the 5.0 The Third Great Refactor milestone Apr 12, 2020
@djotaku djotaku self-assigned this Apr 12, 2020
This was referenced Apr 12, 2020
Closed
Closed
djotaku added a commit that referenced this issue Jun 21, 2020
@djotaku
Finished getting all the code mypy compliant.
08bb7e6 
At this point it mostly meant fixing a couple little things, but in participant.py it
did end up making things a little easier to understand if reading the code.

If this works on Github CI then issue #105 will be closed.
@djotaku djotaku closed this as completed Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djotaku djotaku

Labels
mypy related to static typing in python
Projects
None yet
Milestone
5.0 The Third Great Refactor
Development

No branches or pull requests
1 participant
@djotaku