Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grab team donations #24

Closed
djotaku opened this issue Sep 29, 2019 · 2 comments
Closed

grab team donations #24

djotaku opened this issue Sep 29, 2019 · 2 comments
Assignees
@djotaku
Labels
enhancement output data data to create from the JSON to put into OBS or XSplit pytest related to making more unit tests refactor issues involving refactoring code
Projects
Roadmap
Milestone
5.0 The Third Gre...

Comments

@djotaku
Copy link
Owner

djotaku commented Sep 29, 2019

This is in the case that during a livestream a team may be more interested in donations to the team as a whole instead of for the current participant. This issue may involve a refactor to move the Donor out of the extralifedonations.py and into its own file to be used by both extralifedonations.py and team.py. Will probably not be done before this year's Extra Life day.
@djotaku djotaku added this to the Team Info Enhancement milestone Sep 29, 2019
@djotaku djotaku self-assigned this Sep 29, 2019
@djotaku djotaku added this to For 3.0 in Roadmap Oct 1, 2019
@djotaku djotaku moved this from For 3.0 to For 4.0 in Roadmap Oct 9, 2019
@djotaku djotaku modified the milestones: Team Info Enhancement, 4.2.0 Enhancement Tracker Customizations, 4.3.0 Apr 6, 2020
@djotaku
Copy link
Owner Author

djotaku commented Apr 10, 2020

This is going to be affected by my 5.0 refactor, so rather than do it only to have it redone, I'm going to move it to the 5.0 milestone.

@djotaku
Copy link
Owner Author

djotaku commented Jul 5, 2020

Current thought process is to move _get_donations out of participant.py and into donations.py. It would either live outside the class or be a static method. I think perhaps outside the class makes more sense.
Sub-tasks:

  • Move _get_donations into donations and make modifications as necessary to reflect that it's been moved - both in donations and in participant.py. I think that by having made it into a functional programming function before, this actually shouldn't be too much work. (Mostly in the first 'else')
  • modify unit tests - hopefully just moving it over from participant to donations.
  • Add code to Team to get donations - needs variables, dictionaries, functions. Formatting. Needs to output to text files.
  • there may be others, but that's what I can think of

@djotaku djotaku added output data data to create from the JSON to put into OBS or XSplit pytest related to making more unit tests refactor issues involving refactoring code labels Jul 5, 2020
djotaku added a commit that referenced this issue Jul 14, 2020
@djotaku
🔧 Moved get_donation code into donation
48ba650 
Essentially, I need to do the same thing in team.py as in participant.py, so
I moved the function out so that I'm not repeating code. Now I can start to
add the code to team.py for issue #24.
@djotaku djotaku mentioned this issue Jul 14, 2020
Closed
djotaku added a commit that referenced this issue Jul 14, 2020
@djotaku
🔧 Issue #24 done except for pytest
ba5ffa6 
OK, I am now writing text files for team donation data. Just need to fix up my pytests.
djotaku added a commit that referenced this issue Jul 14, 2020
@djotaku
🔧 Issue #24 done
d5c9ba1 
And pytests completed, too.
@djotaku djotaku mentioned this issue Jul 14, 2020
Merged
@djotaku djotaku closed this as completed Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djotaku djotaku

Labels
enhancement output data data to create from the JSON to put into OBS or XSplit pytest related to making more unit tests refactor issues involving refactoring code
Projects
No open projects
Roadmap
For 4.0
Milestone
5.0 The Third Great Refactor
Development

No branches or pull requests
1 participant
@djotaku