Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Owner of multiple wifi points #4

Closed
judeibe opened this issue Nov 25, 2020 · 7 comments
Closed

Owner of multiple wifi points #4

judeibe opened this issue Nov 25, 2020 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@judeibe
Copy link

judeibe commented Nov 25, 2020

I manage my parent's wifi points as well as mine. Is it possible as part of the integration to choose which group to use? I messed around with the API and looks as if an array of groups is passed if the user has more than one.

@djtimca
Copy link
Owner

djtimca commented Nov 26, 2020

I don't have a way to test that scenario to see what data is returned. Are you able to post a sample file which would highlight how that data is represented when it is returned from the API?

@djtimca djtimca self-assigned this Nov 26, 2020
@djtimca djtimca added the enhancement New feature or request label Nov 26, 2020
@judeibe
Copy link
Author

judeibe commented Nov 27, 2020

On this api call https://googlehomefoyer-pa.googleapis.com/v2/groups?prettyPrint=false the googlewifi library seems to pull the first id from groups. This is from the postman collection

// The first system's ID
pm.environment.set("system_id", jdata["groups"][0]["id"]);

{
    "groups": [
        {
            "id": "AAAAAA6aoPQ",
            ....,
        },
       {
           "id": "AAAAABhsip0",
           ....,
        }
     ]
}

@djtimca
Copy link
Owner

djtimca commented Nov 27, 2020

That is odd then... in my library I iterate through the groups to capture all systems that are returned. Is the pm.environment code you listed from postman somewhere that I can look at?

@judeibe
Copy link
Author

judeibe commented Nov 27, 2020 via email

@djtimca
Copy link
Owner

djtimca commented Nov 27, 2020

Thanks @judeibe that's one of the docs I've been using to pull this together. But I am actually iterating through the systems in groups in my library so I'm wondering if the issue might be that Google isn't actually returning all of the systems under the account. Might be related to the token approach to authentication. I'll see if I can't put together a tool to get some test data in the way I'm pulling it so i can validate.

@judeibe
Copy link
Author

judeibe commented Nov 27, 2020

I'll take a look at the api repo and if I can pin point the issue, I am facing I'll either create a new issue or pr.

@djtimca
Copy link
Owner

djtimca commented Dec 4, 2020

Fixed in latest push. Thanks @judeibe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants