Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print instead of error #102

Closed
paskino opened this issue Apr 15, 2021 · 1 comment
Closed

Print instead of error #102

paskino opened this issue Apr 15, 2021 · 1 comment

Comments

@paskino
Copy link
Collaborator

paskino commented Apr 15, 2021

Here the code prints a "warning" to the user. However, this may go unnoticed.

The effect is an empty phantom. IMO the code should raise an exception, or possibly return None
@dkazanc
Copy link
Owner

dkazanc commented Apr 16, 2021

thanks, yes I'm currently adding a couple of other things and will fix that as well.

dkazanc added a commit that referenced this issue Apr 16, 2021
@dkazanc
fixes according to #102, jupyter norebooks, binder batch
cc75e4a
@dkazanc dkazanc closed this as completed Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dkazanc @paskino