-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image snapshots do not match "Expected image to be the same size as the snapshot.." #76
Comments
Here are the two errors different error messages from jest-image-snapshot https://github.com/americanexpress/jest-image-snapshot/blob/48bc2e4b0a980c0a68a7896612ae9fd1dfd4a644/src/index.js#L63 |
thanks @test-pilott - I've never actually use the image diff. Also, @mnikkane was kind enough to open a PR for this capability in the first place. I can try to look at it, but I'll be greatly delayed (weeks) before I could look at fixing this. Alternatively, you can open a PR for this and beat me to it 😄 |
@dkelosky I have a PR but have no permissions to push the feature branch. Help? |
Thats great, thank you! I assume you cloned this repo to make your branch. Instead, please fork the repo, open a branch, push there, and then open the PR. |
fixed by #77 and published @1.13.2, thanks! |
First of all, thanks for this awesome html reporter!
I get this issue when the image snapshot fails for a different error and this doesn't get picked up by the matcher in jest-stare so the snapshot diff is not copied and rendered.
Error: Expected image to be the same size as the snapshot (2370x6290), but was different (2370x6330).
Relevant code line:
jest-stare/src/render/diff/ImageSnapshotDifference.ts
Line 12 in ac83ee4
It just needs to additionally match against
Expected image to be the same size as the snapshot
.Thanks.
The text was updated successfully, but these errors were encountered: