Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per topic counter #16

Open
berkovskyy opened this issue Apr 23, 2020 · 3 comments · May be fixed by #17
Open

Per topic counter #16

berkovskyy opened this issue Apr 23, 2020 · 3 comments · May be fixed by #17
Assignees

Comments

@berkovskyy
Copy link

It would be great to have counter working on a per topic basis (similar to rbe node). Example use case would be counting number of failures from ping node.

@dkern dkern self-assigned this Apr 23, 2020
@dkern
Copy link
Owner

dkern commented Apr 23, 2020

I'm not sure if this is worth implementing it and if this is a good idea. There could possible an endless amount of topics to store. If you want to count on a single topic, put a topic filtering node in front of it, so you only count the messages you want to. That is pretty easy and can be customize by everyone on it's own. I think that it the best approach.

@berkovskyy
Copy link
Author

Filtering approach won't work in many cases. In my particular one I am checking connectivity to 20+ hosts by triggering ping node with list of ip addresses which is formed dynamically. The ping node emits a message per host with the message containing result of ping and "topic" set to ip address. I am looking to count number of failed pings per host and trigger different actions accordingly.

@dkern
Copy link
Owner

dkern commented Apr 23, 2020

I understand what you want to do. Actually, i think the node one would be still the wrong node to use here imo. That would be a better job for a throttle node. But to be honest, it didn't support topics as well. ;) But i think i would rather implement a topic split in the throttle node, than in the counter node. I think it makes more sense ...

@berkovskyy berkovskyy linked a pull request Apr 26, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants