Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Targeted certain chat messages specifically at oneself. #1388

Merged
merged 33 commits into from May 23, 2022

Conversation

AdamPlenty
Copy link
Contributor

No description provided.

@AdamPlenty AdamPlenty changed the title Targeted messages Targeted certain chat messages specifically at oneself. Apr 29, 2022
@AdamPlenty AdamPlenty marked this pull request as ready for review April 29, 2022 19:35
@Loobinex Loobinex self-requested a review April 30, 2022 00:35
@Loobinex
Copy link
Member

Loobinex commented May 2, 2022

I tested some of your messages and seems to work fine.

src/game_merge.h Outdated Show resolved Hide resolved
Copy link
Member

@Loobinex Loobinex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That messages take a player into account is good, but for many it would be nice if in multiplayer everybody saw the console command being used. Anything that could remotely give an advantage in multiplayer.

Could those messages be set to something like -1 or all_players to expose the cheater?

@Loobinex Loobinex merged commit 1bff24c into dkfans:master May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants