Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dropping gold on random rooms #1708

Merged
merged 3 commits into from Jul 31, 2022
Merged

Fixed dropping gold on random rooms #1708

merged 3 commits into from Jul 31, 2022

Conversation

Loobinex
Copy link
Member

Also fixed recent build warning and gold rubble being created at imp feet

@Loobinex Loobinex requested a review from AdamPlenty July 30, 2022 12:45
}
efftng = create_shot_hit_effect(&shotng->mappos, shotng->owner, eff_kind, smpl_idx, range);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't the rubble go into the wall if we use shotng->mappos?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very nice, coming from where you hit the wall instead of from where your feet are.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I noticed that the rocks sometimes go into the wall, which we don't want, surely?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nicer if the rocks fell, but the bigger rocks from destroying dirt also get stuck in neighboring dirt slabs. It seems more correct to me then rocks spawning at the feet, with further improvement possible to make effect elements not stay stuck in walls, but that's for blood splats and everything too.

I still prefer how this looks. Do you not share this view?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In instf_dig, the rocks spawn at the digger's location, though that's probably because it can't spawn anywhere else as there's technically no shot.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, and you can't really notice it anyway, since you're watching from above.

@Loobinex Loobinex merged commit 225b3da into master Jul 31, 2022
@Loobinex Loobinex deleted the dropgold branch July 31, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants