Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix make all being slow #2553

Merged
merged 1 commit into from Aug 23, 2023
Merged

Conversation

rainlizard
Copy link
Contributor

make all is taking an extra ~2 seconds or so due to the silly changes I made in #2544 to make it write ALL the checksums to .header_checksum and print all changes to the terminal. My first method was a lot faster.

I've kept the ./src/ change I originally made, so only files in the /src/ directory will be looked at. And I've also made another change to use md5sum instead of sha256sum, which is also a little faster.

@Loobinex Loobinex merged commit 759b39a into dkfans:master Aug 23, 2023
@yani
Copy link
Contributor

yani commented Aug 24, 2023

Have you tried CRC-32? It's even faster than md5 and perfect for looking into file changes.

Many tools also just use the last modified time and maybe even the last modified timestamp of the directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants