Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUICK_MESSAGE and DISPLAY_MESSAGE should now take spells, rooms, and … #986

Merged
merged 1 commit into from Apr 6, 2021

Conversation

AdamPlenty
Copy link
Contributor

…certain Query values for the player parameter.

…certain Query values for the player parameter.
@Loobinex
Copy link
Member

Loobinex commented Apr 3, 2021

Where could one find the query values?

@Loobinex Loobinex self-requested a review April 3, 2021 23:46
@AdamPlenty
Copy link
Contributor Author

Where could one find the query values?

The text values or the sprite ID values?

@Loobinex
Copy link
Member

Loobinex commented Apr 4, 2021

Where could one find the query values?

The text values or the sprite ID values?

Which config file could I point the user to to find the query options he can use?

@AdamPlenty
Copy link
Contributor Author

Where could one find the query values?

The text values or the sprite ID values?

Which config file could I point the user to to find the query options he can use?

I don't think there is one; I had to hard-code the names like with 'None'.

@Loobinex
Copy link
Member

Loobinex commented Apr 6, 2021

Ok, I don't really see much use in them, I did notice it to be problematic to be case sensitive.
I looked and if you use strncasecmp instead of strcasecmp you could make it case insensitive. Could you do this for these options, and for 'None' too?

@AdamPlenty
Copy link
Contributor Author

Ok, I don't really see much use in them, I did notice it to be problematic to be case sensitive.
I looked and if you use strncasecmp instead of strcasecmp you could make it case insensitive. Could you do this for these options, and for 'None' too?

It should already be case-insensitive. When I tested it, I put the values in all-caps, and it worked fine for me. What's different about strncasecmp?

@Loobinex
Copy link
Member

Loobinex commented Apr 6, 2021

It should already be case-insensitive. When I tested it, I put the values in all-caps, and it worked fine for me. What's different about strncasecmp?

Today it worked fine for me too. I don't know how I messed up yesterday.

@Loobinex Loobinex merged commit 8a55a89 into dkfans:master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants