Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type Anomaly should allow to store more than one suggestion. #22

Closed
reckart opened this issue May 12, 2015 · 7 comments
Closed

Type Anomaly should allow to store more than one suggestion. #22

reckart opened this issue May 12, 2015 · 7 comments
Labels
⭐️ Enhancement New feature or request
Milestone

Comments

@reckart
Copy link
Member

reckart commented May 12, 2015

Background: most spelling correctors return more than one suggestion.
The alternative would be to create one annotation per suggestion and merge later via
offset comparison (which sounds like too much of a hassle).

Original issue reported on code.google.com by torsten.zesch on 2011-08-08 06:51:17

@reckart
Copy link
Member Author

reckart commented May 12, 2015

I'd suggest to use an array of suggestions. The uimaFIT FSCollectionFactory should come
in handy here.

I suppose there should also be some indication of the quality/relevance of the suggestion
if that is provided by the underlying tool. So we would need a new type "SuggestedAction"
or something like that.

I think we may still want to keep the separation between SpellingAnomaly and GrammarAnomaly
and add the array to the general Anomaly type.

Original issue reported on code.google.com by richard.eckart on 2011-08-08 07:15:19

@reckart
Copy link
Member Author

reckart commented May 12, 2015

Array of suggestions sounds good.
I also think that it should be applied directly to the Anomaly type.

Regarding the quality/relevance: Some tools even output a [0,1] relevance score.
Is there a way to store an array of tuples?

Original issue reported on code.google.com by torsten.zesch on 2011-08-08 07:22:07

@reckart
Copy link
Member Author

reckart commented May 12, 2015

ArrayFS is typed. So you always store an array of FeatureStructures of a certain type.
The SuggestedAction type should have the information about the score.

Original issue reported on code.google.com by richard.eckart on 2011-08-08 08:25:39

@reckart
Copy link
Member Author

reckart commented May 12, 2015

Torsten, this is fixed now, right?

Original issue reported on code.google.com by richard.eckart on 2011-08-30 18:23:57

@reckart
Copy link
Member Author

reckart commented May 12, 2015

(No text was entered with this change)

Original issue reported on code.google.com by richard.eckart on 2011-08-30 18:27:29

  • Labels added: Milestone-1.2.0

@reckart
Copy link
Member Author

reckart commented May 12, 2015

(No text was entered with this change)

Original issue reported on code.google.com by torsten.zesch on 2011-09-29 08:39:14

@reckart
Copy link
Member Author

reckart commented May 12, 2015

Fixed.
---
rev 156

Original issue reported on code.google.com by richard.eckart on 2011-10-02 15:28:06

@reckart reckart closed this as completed May 12, 2015
@reckart reckart modified the milestone: 1.2.0 May 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐️ Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant