Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qconversion.c needs major cleanup #14

Closed
dkriegner opened this issue Nov 27, 2015 · 2 comments
Closed

qconversion.c needs major cleanup #14

dkriegner opened this issue Nov 27, 2015 · 2 comments
Assignees
@dkriegner
Labels
2.0 auto-migrated c-lib clean-up sourceforge

Comments

@dkriegner
Copy link
Owner

For performance reasons there are many variants of the ang2q_conversion for point, linear, and area detectors. the respective different functions for point, linear, and area detector however share the same interface to the python code and the variable checking/conversion code should therefore be moved to a common wrapper function!

This should make the code more readable and managable in future!

Reported by: dkriegner
@dkriegner
Copy link
Owner Author

  • status: open --> closed
  • assigned_to: Dominik Kriegner

Original comment by: dkriegner

@dkriegner
Copy link
Owner Author

fixed by commits [e65c96], [068c68], [53587d]
roughly 1000 lines of code could be removed without changing any feature!

Original comment by: dkriegner

@dkriegner dkriegner self-assigned this May 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkriegner dkriegner

Labels
2.0 auto-migrated c-lib clean-up sourceforge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dkriegner