Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exportVariable: Using / instead of \n as separator #27

Closed
passsy opened this issue Jul 11, 2022 · 1 comment · Fixed by #30
Closed

exportVariable: Using / instead of \n as separator #27

passsy opened this issue Jul 11, 2022 · 1 comment · Fixed by #30
Assignees
@dkrutskikh
Labels
bug Something isn't working

Comments

@passsy
Copy link

passsy commented Jul 11, 2022

I was comparing the js implementation with the dart implementation here. js uses os.EOL but dart uses p.context.separator instead. Those are not identical!

actions-toolkit-dart/lib/src/core/core.dart

Line 22 in 594a1fd

final separator = p.context.separator;

Please replace it with

final eol = Platform.isWindows ? '\r\n' : '\n';
@passsy passsy changed the title Using / instead of \n exportVariable: Using / instead of \n as separator Jul 11, 2022
@dkrutskikh dkrutskikh added the bug Something isn't working label Jul 12, 2022
@dkrutskikh dkrutskikh self-assigned this Jul 12, 2022
@dkrutskikh dkrutskikh mentioned this issue Jul 12, 2022
Merged
@dkrutskikh
Copy link
Owner

@passsy fixed in 0.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkrutskikh dkrutskikh

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: exportVariable calls right file command dkrutskikh/actions-toolkit-dart
2 participants
@passsy @dkrutskikh