Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warnings in comment (for now: regression PR not against master) #57

Merged
merged 3 commits into from Jun 22, 2017

Conversation

wilzbach
Copy link
Member

A first attempt to show helpful warnings (or errors) to a PR submitter (#8).

  • In the first commit this adds warnings.d where in the future more warning generator can lay. This commit doesn't modify the output.

  • The second commit extends the bugzilla query by requesting more attributes (e.g. severity)

  • The third commit combines the first two and emits a warnings when a critical/major/regression/blocking PR isn't based onto stable

Again this is meant as first iteration and we probably have to fine tune this (and can hopefully add more warning generators).
One refactoring step that we should do in any case is to find a common "Cache" format for all information already requested by the diverse APIs - passing them around as function parameters doesn't scale that well.

@wilzbach wilzbach changed the title Show warnings in comment Show warnings in comment (for now: regression PR not against master) Feb 20, 2017
@wilzbach wilzbach force-pushed the show-warnings-in-comment branch 3 times, most recently from 298339a to 0c735ea Compare June 22, 2017 04:33
@dlang-bot
Copy link
Collaborator

Thanks for your pull request, @wilzbach! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some things that can help to speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

@wilzbach
Copy link
Member Author

@MartinNowak I will merge this as well now, because we agreed that we want to show messages and this PR has been hanging in the queue for four months now & today I have my dlang-bot squash morning which I use to monitor the effect of our deployed changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants