Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webhook signature validation spuriously fails #27

Closed
MartinNowak opened this issue Mar 3, 2017 · 3 comments
Closed

webhook signature validation spuriously fails #27

MartinNowak opened this issue Mar 3, 2017 · 3 comments

Comments

@MartinNowak
Copy link
Member

For quite a few PRs github shows that it got a 400 response with a signature mismatch.
Provided signature [e6a7a2d4f9d5c65873795035a9bfcda0b90c14d5] did not match to calculated
@MartinNowak
Copy link
Member Author

Fixed by switching all hooks to application/json.

@MartinNowak
Copy link
Member Author

Tracked it down to jenkinsci/github-plugin#134 (comment).

@mirekphd
Copy link

mirekphd commented Apr 1, 2023

@MartinNowak This bug in Jenkins Github Plugin you tracked down in 2017 is still there in 2023. It happens to me after each internet domain change (e.g. from .com to .org) in the Payload URL field on Github's Webhooks > Manage webhook page.

But your workaround from 5 years ago is still valid.

Yes, things are sometimes moving very slow indeed when it comes to fixing bugs in open source...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MartinNowak @mirekphd