Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why multiple duplicates hasn't been merged? #25

Closed
faywong opened this issue Jul 1, 2020 · 10 comments
Closed

Why multiple duplicates hasn't been merged? #25

faywong opened this issue Jul 1, 2020 · 10 comments

Comments

@faywong
Copy link

faywong commented Jul 1, 2020

for example:

file_a.c line 100 duplicates to file_a.c line 200 and file_a.c line 500 and file_a.c line 600, expecte the result to be

file_a.c line 100 file_a.c line 200 file_a.c 500 are duplicated other than:

line 100 duplicates to line 200, line 500 duplicates to line 600.

@faywong faywong changed the title Why no multiple duplicates hasn't been merged? Why multiple duplicates hasn't been merged? Jul 1, 2020
@dlidstrom
Copy link
Owner

I am not sure exactly why this happens. Does this cause an issue for you? I guess no, since the program found all cases of duplication, right?

@ArsMasiuk
Copy link
Contributor

for example:

file_a.c line 100 duplicates to file_a.c line 200 and file_a.c line 500 and file_a.c line 600, expecte the result to be

file_a.c line 100 file_a.c line 200 file_a.c 500 are duplicated other than:

line 100 duplicates to line 200, line 500 duplicates to line 600.

Do you mean that the program says nothing about line 600 in the output?

@faywong
Copy link
Author

faywong commented Jul 24, 2020

I mean duplicate lines maybe should be expressed as:

“duplicated content": [all the occurences, such as "file1:1", "file2:2" , "file3:4" ... ]

@ArsMasiuk
Copy link
Contributor

I mean duplicate lines maybe should be expressed as:

“duplicated content": [all the occurences, such as "file1:1", "file2:2" , "file3:4" ... ]

Well I'm currently (slow) working on a GUI frontend for Duplo: https://github.com/ArsMasiuk/duploq
The tool tries to aggregate Duplo's output as well, hope that's what you are talking about?

@dlidstrom
Copy link
Owner

Good suggestion @faywong . I’ll think a bit about this, but can’t promise anything as of now.

@faywong
Copy link
Author

faywong commented Aug 13, 2020

I mean duplicate lines maybe should be expressed as:

“duplicated content": [all the occurences, such as "file1:1", "file2:2" , "file3:4" ... ]

Well I'm currently (slow) working on a GUI frontend for Duplo: https://github.com/ArsMasiuk/duploq
The tool tries to aggregate Duplo's output as well, hope that's what you are talking about?

Cool, aggregate Duplo's output in a post-process step is also a good solution. Also i have opt. the algorithm to boost the performance.

@dlidstrom
Copy link
Owner

@faywong cool, is that something you can share?

@faywong
Copy link
Author

faywong commented Aug 19, 2020

@faywong cool, is that something you can share?

Currently is only capable of use in our case, hasn't reach the expected performance yet. Anyway, i will update here if we're ready to contribute a better version.

@dlidstrom
Copy link
Owner

In the spirit of open source and all future users of Duplo, please do.

@dlidstrom
Copy link
Owner

@faywong Is there something you can share with your implementation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants