Don't abuse __builtins__

According to Jean-Paul Calderone at https://bugs.launchpad.net/pycrypto/+bug/785150: `__builtins__` is an implementation detail of CPython. It takes on inconsistent values at various times. The use in `common.py` happens to work on recent version of CPython, but it doesn't work on PyPy. The only thing you should ever do, when you're doing this sort of thing, is "import __builtin__; __builtin__.foo".
pycrypto · Oct 11, 2011 · 25a0553 · 25a0553
1 parent 7401e64
commit 25a0553
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/ACKS b/ACKS
@@ -21,6 +21,7 @@ Ian Bicking
 Joris Bontje
 Antoon Bosselaers
 Andrea Bottoni
+Jean-Paul Calderone
 Sergey Chernov
 Geremy Condra
 Jan Dittberner

diff --git a/lib/Crypto/SelfTest/Cipher/common.py b/lib/Crypto/SelfTest/Cipher/common.py
@@ -38,7 +38,7 @@
     def dict(**kwargs):
         return kwargs.copy()
 else:
-    dict = __builtins__['dict']
+    dict = dict
 
 class _NoDefault: pass        # sentinel object
 def _extract(d, k, default=_NoDefault):

diff --git a/lib/Crypto/SelfTest/Hash/common.py b/lib/Crypto/SelfTest/Hash/common.py
@@ -38,7 +38,7 @@
     def dict(**kwargs):
         return kwargs.copy()
 else:
-    dict = __builtins__['dict']
+    dict = dict
 
 
 class HashSelfTest(unittest.TestCase):