Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't make assumptions in List.append() and extend() #84

Closed
dloscutoff opened this issue Mar 30, 2024 · 0 comments
Closed

Don't make assumptions in List.append() and extend() #84

dloscutoff opened this issue Mar 30, 2024 · 0 comments
Labels
minor-bug Not ideal behavior, but doesn't break anything.
Milestone

Comments

@dloscutoff
Copy link
Owner

Comment in List.append(): "This assumes that item is an instance of a Pip type--unpredictable behavior may follow if it's not." Instead of assuming, it would be pretty simple to check and raise TypeError when appropriate, which would be a lot better than unpredictable behavior. Same goes for List.extend(), though the check will be a bit more complicated.

@dloscutoff dloscutoff added the minor-bug Not ideal behavior, but doesn't break anything. label Mar 30, 2024
@dloscutoff dloscutoff added this to the v1.3 milestone Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor-bug Not ideal behavior, but doesn't break anything.
Projects
None yet
Development

No branches or pull requests

1 participant