Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save env-kwargs when some are passed #11

Closed
araffin opened this issue May 20, 2020 · 2 comments · Fixed by #30
Closed

Save env-kwargs when some are passed #11

araffin opened this issue May 20, 2020 · 2 comments · Fixed by #30
Labels
enhancement New feature or request help wanted Help from contributors is needed

Comments

@araffin
Copy link
Member

araffin commented May 20, 2020 •
edited

maybe save the seed to? (need to double check that)
@araffin araffin added the enhancement New feature or request label May 20, 2020
@araffin araffin mentioned this issue May 29, 2020
Closed
@SammyRamone
Copy link
Contributor

I think saving the seed would be a good idea.
Do you have a preference where to save this data? Should it be included to the config yaml that currently saves the hyperparameters, or should it be in an extra file?
I would be willing to implement it and do a PR, since I would like to have this feature too.

@araffin
Copy link
Member Author

araffin commented Jun 24, 2020

should it be in an extra file?

I would say extra file for the env hyperparameters

@araffin araffin added the help wanted Help from contributors is needed label Jun 24, 2020
@SammyRamone SammyRamone mentioned this issue Jul 1, 2020
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Help from contributors is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Save args SammyRamone/rl-baselines3-zoo
2 participants
@araffin @SammyRamone