Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature-Request] make_vec_env for bsuite environments #67

Closed
m-rph opened this issue Jun 19, 2020 · 3 comments
Closed

[Feature-Request] make_vec_env for bsuite environments #67

m-rph opened this issue Jun 19, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@m-rph
Copy link
Contributor

m-rph commented Jun 19, 2020

Motivation

Bsuite environments are short/simple to run and are often good validation environments. The idea is to implement the equivalent of make_atari/make_vec_env but for the bsuite environments.

Details

More or less the same implementation as make_vec_env, except the bsuite environments will also be wrapped in an adapter to make them compatible with the gym interface. This will also be optional, and available iff bsuite is installed.

@araffin araffin added the enhancement New feature or request label Jun 19, 2020
@araffin
Copy link
Member

araffin commented Jun 19, 2020

Tell me if I'm wrong, but by looking at that code:

make_vec_env(lambda: env, wrapper_class=bsuite.utils.gym_wrapper.GymFromDMEnv)

would work, no?

@m-rph
Copy link
Contributor Author

m-rph commented Jun 19, 2020

Ah, sorry, mb. I was under the impression that make_vec_env only took strings so loading bsuite env would be slightly more involved.

@m-rph m-rph closed this as completed Jun 19, 2020
@araffin
Copy link
Member

araffin commented Jun 19, 2020

In fact, it expects an env class or a string (I updated my example)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants