Improvements to the integration tests: #7
Conversation
* Use the tempfile crate instead of hard-coding temporary file names * Must use _exit(0) at the end of child processes, so we don't run the Rust destructors in both children and parents. * Minimize use of `unsafe` * Always run `cap_enter` in a child process.
| capsicum::enter().unwrap(); | ||
| let path = CString::new("lib.rs").unwrap(); | ||
| let _ = dir.open_file(path, 0, None).unwrap(); | ||
| unsafe { libc::_exit(0) }; |
There was a problem hiding this comment.
nit: Would you be up for adding a failure case? We could use tempdir to create a directory which we wouldn't have access to, or do something like a lookup in "./tests". We probably should avoid using "./src" and "./tests" which I think wouldn't work in some cases if the tests binary was run manually outside of the root crate directory.
There was a problem hiding this comment.
Yeah, I was noticing the same thing about "./src".
There was a problem hiding this comment.
It looks like there are other problems too. We aren't monitoring the child process's status correctly. I suggest we merge this PR as-is, and then I'll do another that uses Nix as a dependency in order to use waitpid correctly, which will help fix these problems.
unsafecap_enterin a child process.