Add pv argument to get_all_pvs that allows a glob pattern. #53
Conversation
willrogers
force-pushed
the
pv-search
branch
from
8ac80e4
to
23d14dd
Compare
Pull Request Test Coverage Report for Build 368
💛 - Coveralls |
|
@willrogers Any reason why this was not merged? |
|
I don't remember. Does it look ok to you? |
|
It looks sensible enough. I will test it, and assuming it works, rebase and merge. |
|
OK I think I know the reason why you postponed this. I get the same test failure that you do. Adding the extra argument here makes this the only use with more than one URL parameter. Because of the non-deterministic ordering in dictionaries, two successive calls to My preferred way to fix this would be to change I guess at the time you questioned whether this was worth it. I think it probably is so I'll go ahead and do it for neatness' sake. |
|
That sounds right. Deterministic URLs make sense I think. |
Addition of `pv` argument to `RestClient.get_all_pvs` showed up a problem in `_construct_url` that ordering of URL parameters was not repeatable because they are got from the kwargs as a dict. We get around this by sorting by key and storing as a list of tuples of (key, value). We assume that no-one cares what the order of URL parameters is, as long as it is deterministic.
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
==========================================
+ Coverage 97.60% 97.62% +0.02%
==========================================
Files 10 10
Lines 625 632 +7
==========================================
+ Hits 610 617 +7
Misses 15 15
Continue to review full report at Codecov.
|
|
Thanks, looks good. |
No description provided.