Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rest_client: single item endpoints not detected when path has extension #1393

Closed
rudolfix opened this issue May 21, 2024 · 0 comments · Fixed by #1394
Closed

rest_client: single item endpoints not detected when path has extension #1393

rudolfix opened this issue May 21, 2024 · 0 comments · Fixed by #1394
Assignees
Labels
bug Something isn't working

Comments

@rudolfix
Copy link
Collaborator

dlt version

0.4.11

Describe the problem

Single item endpoint detector does support paths like /item/{id} but does not support /item/{id}.json (extension after path param)

Expected behavior

paths with extension are correctly detected

Steps to reproduce

Generate a pipeline for https://gist.githubusercontent.com/wing328/44a6cb6c899feda4c2bd44747e9dcbc8/raw/737d3cf34daeef32280c66c5790c7de1a7b26905/hacker_news_api_swagger.json and try to run it

Operating system

Linux, macOS, Windows

Runtime environment

Local

Python version

3.8

dlt data source

No response

dlt destination

No response

Other deployment details

No response

Additional information

No response

@rudolfix rudolfix self-assigned this May 21, 2024
@rudolfix rudolfix added the bug Something isn't working label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant