Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running "DESTDIR=/usr/local make install" places files unexpectedly. #1

Closed
robertdebock opened this issue Oct 28, 2017 · 2 comments
Closed

Comments

@robertdebock
Copy link

When I run "DESTDIR=/usr/local make install" the files are places in unexpected places.

What I've done:

git clone https://github.com/dm-vdo/vdo.git
cd vdo
make
DESTDIR=/usr/local make install

What I see in /usr/local:

COPYING
examples
man8
statistics
utils
vdo
vdodumpconfig
vdoforcerebuild
vdoformat
vdomgmnt
vdoprepareupgrade
vdoreadonly
vdo.service
vdostats

If I conclude the list above, it contains:

  • binaries not in ./bin or ./sbin
  • man pages
  • examples
  • services not in /usr/lib/systemd/system/
  • COPYING

Am I using "make" incorrectly?

BTW: I can help make an RPM out of this software if you'd like that.

@robertdebock robertdebock changed the title Running "DESTDIR=/usr/local make install" places files unlogically. Running "DESTDIR=/usr/local make install" places files unexpectedly. Oct 28, 2017
@rhawalsh
Copy link
Member

rhawalsh commented Nov 1, 2017

Hi. You should be calling it as 'make install DESTDIR=/usr/local'.

Thanks for the offer of assistance with RPMs. We already have a set of RPMs. We will work on posting the specfiles into these repositories.

Our call in the spec is as follows:

 make install DESTDIR=$RPM_BUILD_ROOT bindir=%{_bindir} \
   defaultdocdir=%{_defaultdocdir} name=%{name} \
   python_sitelib=%{python_sitelib} mandir=%{_mandir} \
   unitdir=%{_unitdir}

@corwin
Copy link
Contributor

corwin commented Nov 26, 2017

I've just merged a new update to the project which should hopefully fix this build issue. Please let me know if there are still problems.

Thanks,

corwin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants