Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libvirt_volume.main_disk: Can't retrieve volume xxx #88

Closed
MalloZup opened this issue Nov 28, 2016 · 5 comments
Closed

libvirt_volume.main_disk: Can't retrieve volume xxx #88

MalloZup opened this issue Nov 28, 2016 · 5 comments
Labels

Comments

@MalloZup
Copy link
Collaborator

MalloZup commented Nov 28, 2016

How-to-reproduce:

clone sumaform
Take the main.tf-libvirt-testing example.

Terraform get
Terraform apply

run it 3/4 times. ( 2 times will fail with error :

libvirt_volume.main_disk: Can't retrieve volume  sles12sp1

This issue block the provissioning and for production or dayly work is annoyng, because we have to reapply terraform apply.

I cannot sadly determine the cause of this issue, the disk created is there but terraform fails to retrieve it.
It's a race condition. I'm quite sure that the sumaform is not the root cause of the problem.

For additional logs, info, ping me

@MalloZup MalloZup reopened this Jun 21, 2018
@MalloZup MalloZup added the bug label Jul 23, 2018
Repository owner deleted a comment from Bischoff Aug 21, 2018
Repository owner deleted a comment from moio Aug 21, 2018
Repository owner deleted a comment from Bischoff Aug 21, 2018
Repository owner deleted a comment from moio Aug 21, 2018
Repository owner deleted a comment from Bischoff Aug 21, 2018
Repository owner deleted a comment from Bischoff Aug 21, 2018
Repository owner deleted a comment from moio Aug 21, 2018
Repository owner deleted a comment from ktsamis Aug 21, 2018
Repository owner deleted a comment from ktsamis Aug 21, 2018
@MalloZup
Copy link
Collaborator Author

MalloZup commented Aug 21, 2018

To all:

Resuming this issue N 88: this issue was about retrieve volumes by id error race condition

As user we get the error:
libvirt_volume.main_disk: Can't retrieve volume sles12sp1

As @dmacvicar stated in his PR comment, at the end ( so that PR on latest plugin should fix)
and probably (no evidence) related ones like #324 and #88

#353 (comment)

Since this issue was a race condition we cannot test with evidence.

I'm an optimistic person, so i will close this issue.

To all sumaform users @moio @ktsamis @Bischoff : until we don't update and merge this https://github.com/SUSE/spacewalk/issues/5475

is clear that you will continue to have or experiment this issues.

If you have again the error after update, and i mean the error cannot retrieve volume that i post above, feel free to reopen this issue.
For all other type of issues, check out if is a sumaform related issues (it could be that sumaform doesn't use correctly also the new terraform syntax) or open a new issue on the provider if you think is a provider issue.

For every new issue, optimal would be that you run TF_LOG=DEBUG terraform apply so we have full debug.

I will thnk if we can maybe enable TF_LOG=DEBUG in production and saving maybe only the debug info in a special file

@MalloZup
Copy link
Collaborator Author

@moio
Copy link
Collaborator

moio commented Aug 29, 2018

This is actually confirmed to be a core libvirt issue fixed from version 4.3.0 on. Specifically by this patch, that can be applied back to 4.0.0 without issues:

https://bugzilla.redhat.com/show_bug.cgi?id=1576464#c3

@moio
Copy link
Collaborator

moio commented Aug 29, 2018

Reported against Ubuntu as: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1789659
Reported against SUSE distros as: https://bugzilla.suse.com/show_bug.cgi?id=1106420

openSUSE Tumbleweed is not affected

@MalloZup
Copy link
Collaborator Author

thx @moio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants